DOCSP-46750 Kotlin Sync Title Change #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarahemlin
requested changes
Feb 26, 2025
mongoKart
approved these changes
Feb 27, 2025
config/redirects
Outdated
| @@ -8,3 +8,4 @@ symlink: current -> master | |||
|
|
|||
| raw: ${prefix}/ -> ${base}/current/ | |||
| raw: ${prefix}/master -> ${base}/upcoming/ | |||
| [v5.1-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/get-started/run-sample-query | |||
There was a problem hiding this comment.
https://www.mongodb.com/docs/meta/redirects/#rules
Suggested change
| [v5.1-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/get-started/run-sample-query | |
| [v5.1-*]: ${prefix}/${version}/get-started/connect-to-mongodb/ -> ${base}/get-started/run-sample-query/ |
There was a problem hiding this comment.
Ah thanks for the catch!
config/redirects
Outdated
| @@ -8,3 +8,4 @@ symlink: current -> master | |||
|
|
|||
| raw: ${prefix}/ -> ${base}/current/ | |||
| raw: ${prefix}/master -> ${base}/upcoming/ | |||
| [v5.1-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/get-started/run-sample-query | |||
There was a problem hiding this comment.
q: just double-checking that this change should apply only to v5.1 and above?
There was a problem hiding this comment.
5.1 is the lowest version in the version flipper: https://www.mongodb.com/docs/languages/kotlin/kotlin-sync-driver/v5.1/! Should I just do raw instead if that is the case?
There was a problem hiding this comment.
Resolved in slack dms
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.1 v5.1
# Navigate to the new working tree
cd .worktrees/backport-v5.1
# Create a new branch
git switch --create backport-66-to-v5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eee6b3290896ed5340d89315e2efc8c872fea2a8
# Push it to GitHub
git push --set-upstream origin backport-66-to-v5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.1Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32)
This was referenced Feb 27, 2025
shuangela
added a commit
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
to shuangela/docs-kotlin-sync
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32)
shuangela
added a commit
to shuangela/docs-kotlin-sync
that referenced
this pull request
Feb 27, 2025
* change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32)
shuangela
added a commit
that referenced
this pull request
Feb 27, 2025
shuangela
added a commit
that referenced
this pull request
Feb 27, 2025
* DOCSP-46750 Kotlin Sync Title Change (#66) * change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32) * imports in vale action fix * Delete .github/workflows/check-autobuilder.yml * cherrypick --------- Co-authored-by: Rea Rustagi <[email protected]>
shuangela
added a commit
that referenced
this pull request
Feb 27, 2025
* DOCSP-46750 Kotlin Sync Title Change (#66) * change titles * change url and add redirect * add slash * add back old ref based on rea's feedback (cherry picked from commit eee6b32) * imports in vale action fix * Delete .github/workflows/check-autobuilder.yml * cherrypick * realized duplicate /docs in url redirect (#75) (cherry picked from commit 92549a3) cherrypick --------- Co-authored-by: Rea Rustagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46750
Staging Links
Self-Review Checklist